Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1aeede3a authored by Peter Münster's avatar Peter Münster Committed by Greg Kroah-Hartman
Browse files

net: b44: set pause params only when interface is up 

commit e3eb7dd47bd4806f00e104eb6da092c435f9fb21 upstream.

b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers)
unconditionally, but b44::rx_buffers is only valid when the
device is up (they get allocated in b44_open(), and deallocated
again in b44_close()), any other time these are just a NULL pointers.

So if you try to change the pause params while the network interface
is disabled/administratively down, everything explodes (which likely
netifd tries to do).

Link: https://github.com/openwrt/openwrt/issues/13789


Fixes: 1da177e4 (Linux-2.6.12-rc2)
Cc: stable@vger.kernel.org
Reported-by: default avatarPeter Münster <pm@a16n.net>
Suggested-by: default avatarJonas Gorski <jonas.gorski@gmail.com>
Signed-off-by: default avatarVaclav Svoboda <svoboda@neng.cz>
Tested-by: default avatarPeter Münster <pm@a16n.net>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarPeter Münster <pm@a16n.net>
Reviewed-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/87y192oolj.fsf@a16n.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f5417ff5

drivers/net/ethernet/broadcom/b44.c

+8 −6
Original line number Diff line number Diff line
@@ -2033,6 +2033,7 @@ static int b44_set_pauseparam(struct net_device *dev, 
		bp->flags |= B44_FLAG_TX_PAUSE;

	else

		bp->flags &= ~B44_FLAG_TX_PAUSE;

	if (netif_running(dev)) {

		if (bp->flags & B44_FLAG_PAUSE_AUTO) {

			b44_halt(bp);

			b44_init_rings(bp);
@@ -2040,6 +2041,7 @@ static int b44_set_pauseparam(struct net_device *dev, 
		} else {

			__b44_set_flow_ctrl(bp, bp->flags);

		}

	}

	spin_unlock_irq(&bp->lock);



	b44_enable_ints(bp);