Commit 1ad45d0f authored Aug 14, 2019 by Wenwen Wang Committed by Greg Kroah-Hartman Sep 10, 2019

cx82310_eth: fix a memory leak bug



[ Upstream commit 1eca92eef18719027d394bf1a2d276f43e7cf886 ]

In cx82310_bind(), 'dev->partial_data' is allocated through kmalloc().
Then, the execution waits for the firmware to become ready. If the firmware
is not ready in time, the execution is terminated. However, the allocated
'dev->partial_data' is not deallocated on this path, leading to a memory
leak bug. To fix this issue, free 'dev->partial_data' before returning the
error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ac3cc25f

drivers/net/usb/cx82310_eth.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -175,7 +175,8 @@ static int cx82310_bind(struct usbnet dev, struct usb_interface intf)
	}		}
	if (!timeout) {		if (!timeout) {
	dev_err(&udev->dev, "firmware not ready in time\n");		dev_err(&udev->dev, "firmware not ready in time\n");
	return -ETIMEDOUT;		ret = -ETIMEDOUT;
			goto err;
	}		}

	/* enable ethernet mode (?) */		/* enable ethernet mode (?) */