Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1acae6b0 authored Dec 31, 2017 by Eran Ben Elisha Committed by Saeed Mahameed Mar 27, 2018

mlx5: Move dump error CQE function out of mlx5_ib for code sharing



Move mlx5_ib dump error CQE implementation to mlx5 CQ header file in
order to use it in a downstream patch from mlx5e.

In addition, use print_hex_dump instead of manual dumping of the buffer.

Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 28160771

drivers/infiniband/hw/mlx5/cq.c

+1 −7

Original line number	Original line	Diff line number	Diff line
	@@ -267,14 +267,8 @@ static void handle_responder(struct ib_wc wc, struct mlx5_cqe64 cqe,

	static void dump_cqe(struct mlx5_ib_dev dev, struct mlx5_err_cqe cqe)		static void dump_cqe(struct mlx5_ib_dev dev, struct mlx5_err_cqe cqe)
	{		{
	__be32 p = (__be32 )cqe;
	int i;

	mlx5_ib_warn(dev, "dump error cqe\n");		mlx5_ib_warn(dev, "dump error cqe\n");
	for (i = 0; i < sizeof(*cqe) / 16; i++, p += 4)		mlx5_dump_err_cqe(dev->mdev, cqe);
	pr_info("%08x %08x %08x %08x\n", be32_to_cpu(p[0]),
	be32_to_cpu(p[1]), be32_to_cpu(p[2]),
	be32_to_cpu(p[3]));
	}		}

	static void mlx5_handle_error_cqe(struct mlx5_ib_dev *dev,		static void mlx5_handle_error_cqe(struct mlx5_ib_dev *dev,

include/linux/mlx5/cq.h

+6 −0

Original line number	Original line	Diff line number	Diff line
	@@ -193,6 +193,12 @@ int mlx5_core_modify_cq(struct mlx5_core_dev dev, struct mlx5_core_cq cq,
	int mlx5_core_modify_cq_moderation(struct mlx5_core_dev *dev,		int mlx5_core_modify_cq_moderation(struct mlx5_core_dev *dev,
	struct mlx5_core_cq *cq, u16 cq_period,		struct mlx5_core_cq *cq, u16 cq_period,
	u16 cq_max_count);		u16 cq_max_count);
			static inline void mlx5_dump_err_cqe(struct mlx5_core_dev *dev,
			struct mlx5_err_cqe *err_cqe)
			{
			print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET, 16, 1, err_cqe,
			sizeof(*err_cqe), false);
			}
	int mlx5_debug_cq_add(struct mlx5_core_dev dev, struct mlx5_core_cq cq);		int mlx5_debug_cq_add(struct mlx5_core_dev dev, struct mlx5_core_cq cq);
	void mlx5_debug_cq_remove(struct mlx5_core_dev dev, struct mlx5_core_cq cq);		void mlx5_debug_cq_remove(struct mlx5_core_dev dev, struct mlx5_core_cq cq);