Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ac93a30 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

USB: io_edgeport: Use kzalloc 

Use kzalloc rather than the combination of kmalloc and memset.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x,size,flags;
statement S;
@@

-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
 if (x == NULL) S
-memset(x, 0, size);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent b2c57379

drivers/usb/serial/io_edgeport.c

+1 −2
Original line number Diff line number Diff line
@@ -3020,7 +3020,7 @@ static int edge_startup(struct usb_serial *serial) 


	/* set up our port private structures */

	for (i = 0; i < serial->num_ports; ++i) {

		edge_port = kmalloc(sizeof(struct edgeport_port), GFP_KERNEL);

		edge_port = kzalloc(sizeof(struct edgeport_port), GFP_KERNEL);

		if (edge_port == NULL) {

			dev_err(&serial->dev->dev, "%s - Out of memory\n",

								   __func__);
@@ -3033,7 +3033,6 @@ static int edge_startup(struct usb_serial *serial) 
			kfree(edge_serial);

			return -ENOMEM;

		}

		memset(edge_port, 0, sizeof(struct edgeport_port));

		spin_lock_init(&edge_port->ep_lock);

		edge_port->port = serial->port[i];

		usb_set_serial_port_data(serial->port[i], edge_port);