Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a1cb744 authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: fix suspend vs. authentication race 



Since Stanislaw's patch removing the quiescing code, mac80211 had
a race regarding suspend vs. authentication: as cfg80211 doesn't
track authentication attempts, it can't abort them. Therefore the
attempts may be kept running while suspending, which can lead to
all kinds of issues, in at least some cases causing an error in
iwlmvm firmware.

Fix this by aborting the authentication attempt when suspending.

Cc: stable@vger.kernel.org
Fixes: 12e7f517 ("mac80211: cleanup generic suspend/resume procedures")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent c9c3a060

net/mac80211/ieee80211_i.h

+1 −0
Original line number Diff line number Diff line
@@ -1391,6 +1391,7 @@ void ieee80211_sta_reset_conn_monitor(struct ieee80211_sub_if_data *sdata); 
void ieee80211_mgd_stop(struct ieee80211_sub_if_data *sdata);

void ieee80211_mgd_conn_tx_status(struct ieee80211_sub_if_data *sdata,

				  __le16 fc, bool acked);

void ieee80211_mgd_quiesce(struct ieee80211_sub_if_data *sdata);

void ieee80211_sta_restart(struct ieee80211_sub_if_data *sdata);



/* IBSS code */

net/mac80211/mlme.c

+26 −0
Original line number Diff line number Diff line
@@ -3576,6 +3576,32 @@ static void ieee80211_restart_sta_timer(struct ieee80211_sub_if_data *sdata) 
}



#ifdef CONFIG_PM

void ieee80211_mgd_quiesce(struct ieee80211_sub_if_data *sdata)

{

	struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;

	u8 frame_buf[IEEE80211_DEAUTH_FRAME_LEN];



	sdata_lock(sdata);



	if (ifmgd->auth_data) {

		/*

		 * If we are trying to authenticate while suspending, cfg80211

		 * won't know and won't actually abort those attempts, thus we

		 * need to do that ourselves.

		 */

		ieee80211_send_deauth_disassoc(sdata,

					       ifmgd->auth_data->bss->bssid,

					       IEEE80211_STYPE_DEAUTH,

					       WLAN_REASON_DEAUTH_LEAVING,

					       false, frame_buf);

		ieee80211_destroy_auth_data(sdata, false);

		cfg80211_tx_mlme_mgmt(sdata->dev, frame_buf,

				      IEEE80211_DEAUTH_FRAME_LEN);

	}



	sdata_unlock(sdata);

}



void ieee80211_sta_restart(struct ieee80211_sub_if_data *sdata)

{

	struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;

net/mac80211/pm.c

+11 −3
Original line number Diff line number Diff line
@@ -100,10 +100,18 @@ int __ieee80211_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan) 


	/* remove all interfaces that were created in the driver */

	list_for_each_entry(sdata, &local->interfaces, list) {

		if (!ieee80211_sdata_running(sdata) ||

		    sdata->vif.type == NL80211_IFTYPE_AP_VLAN ||

		    sdata->vif.type == NL80211_IFTYPE_MONITOR)

		if (!ieee80211_sdata_running(sdata))

			continue;

		switch (sdata->vif.type) {

		case NL80211_IFTYPE_AP_VLAN:

		case NL80211_IFTYPE_MONITOR:

			continue;

		case NL80211_IFTYPE_STATION:

			ieee80211_mgd_quiesce(sdata);

			break;

		default:

			break;

		}



		drv_remove_interface(local, sdata);

	}