Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19c55148 authored Apr 04, 2016 by Sebastien Buisson Committed by Greg Kroah-Hartman Apr 11, 2016

staging: lustre: fix 'no effect' errors



Fix 'no effect' issues found by Coverity version 6.5.1:

Unsigned compared against 0 (NO_EFFECT)
This greater-than-or-equal-to-zero comparison of an unsigned value
is always true.

Remove useless cast.

Signed-off-by: Sebastien Buisson <sbuisson@ddn.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3907
Reviewed-on: http://review.whamcloud.com/7166


Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e1798006

drivers/staging/lustre/lustre/llite/xattr.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -424,8 +424,7 @@ int ll_getxattr_common(struct inode inode, const char name,
		if (rce && rce->rce_ops == RMT_LSETFACL) {
		ext_acl_xattr_header *acl;

		acl = lustre_posix_acl_xattr_2ext(
		(posix_acl_xattr_header *)buffer, rc);
		acl = lustre_posix_acl_xattr_2ext(buffer, rc);
		if (IS_ERR(acl)) {
		rc = PTR_ERR(acl);
		goto out;

drivers/staging/lustre/lustre/lmv/lmv_obd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -926,7 +926,7 @@ static int lmv_iocontrol(unsigned int cmd, struct obd_export *exp,
		struct obd_quotactl *oqctl;

		if (qctl->qc_valid == QC_MDTIDX) {
		if (qctl->qc_idx < 0 \|\| count <= qctl->qc_idx)
		if (count <= qctl->qc_idx)
		return -EINVAL;

		tgt = lmv->tgts[qctl->qc_idx];