Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19b5a917 authored by Axel Lin's avatar Axel Lin Committed by Linus Walleij
Browse files

pinctrl: tegra: Fix build dependency



I got below build error:
ERROR: "tegra_xusb_padctl_legacy_probe"
 [drivers/phy/tegra/phy-tegra-xusb.ko] undefined!
with below build configuration:
CONFIG_ARCH_TEGRA=y
CONFIG_PINCTRL_TEGRA_XUSB=y
CONFIG_PHY_TEGRA_XUSB=y

The problem is below line in drivers/pinctrl/Makefile
obj-$(CONFIG_PINCTRL_TEGRA)     += tegra/

So even CONFIG_PINCTRL_TEGRA_XUSB=y is set, kbuild still does not compile
the code in drivers/pinctrl/tegra folder if !CONFIG_PINCTRL_TEGRA.

phy-tegra-xusb.c does not use any symbol from pinctrl-tegra.c,
so build pinctrl-tegra.c only when CONFIG_PINCTRL_TEGRA is set.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarJon Hunter <jonathanh@nvidia.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 9ee8ff48
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ obj-$(CONFIG_PINCTRL_PISTACHIO) += pinctrl-pistachio.o
obj-$(CONFIG_PINCTRL_ROCKCHIP)	+= pinctrl-rockchip.o
obj-$(CONFIG_PINCTRL_SINGLE)	+= pinctrl-single.o
obj-$(CONFIG_PINCTRL_SIRF)	+= sirf/
obj-$(CONFIG_PINCTRL_TEGRA)	+= tegra/
obj-$(CONFIG_ARCH_TEGRA)	+= tegra/
obj-$(CONFIG_PINCTRL_TZ1090)	+= pinctrl-tz1090.o
obj-$(CONFIG_PINCTRL_TZ1090_PDC)	+= pinctrl-tz1090-pdc.o
obj-$(CONFIG_PINCTRL_U300)	+= pinctrl-u300.o
+1 −1
Original line number Diff line number Diff line
obj-y					+= pinctrl-tegra.o
obj-$(CONFIG_PINCTRL_TEGRA)		+= pinctrl-tegra.o
obj-$(CONFIG_PINCTRL_TEGRA20)		+= pinctrl-tegra20.o
obj-$(CONFIG_PINCTRL_TEGRA30)		+= pinctrl-tegra30.o
obj-$(CONFIG_PINCTRL_TEGRA114)		+= pinctrl-tegra114.o