Commit 19b51cb5 authored Dec 21, 2017 by Anna-Maria Gleixner Committed by Ingo Molnar Jan 16, 2018

hrtimer: Clean up 'enum hrtimer_mode'



It's not obvious that the HRTIMER_MODE variants are bit combinations,
because all modes are hard coded constants currently.

Change it so the bit meanings are clear; and use the symbols for creating
modes which combine bits.

While at it get rid of the ugly tail comments as well.

Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: Christoph Hellwig <hch@lst.de>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: keescook@chromium.org
Link: http://lkml.kernel.org/r/20171221104205.7269-8-anna-maria@linutronix.de


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 48d0c9be

include/linux/hrtimer.h

+11 −5

Original line number	Diff line number	Diff line
		@@ -28,13 +28,19 @@ struct hrtimer_cpu_base;

		/*
		* Mode arguments of xxx_hrtimer functions:
		*
		* HRTIMER_MODE_ABS - Time value is absolute
		* HRTIMER_MODE_REL - Time value is relative to now
		* HRTIMER_MODE_PINNED - Timer is bound to CPU (is only considered
		* when starting the timer)
		*/
		enum hrtimer_mode {
		HRTIMER_MODE_ABS = 0x0, /* Time value is absolute */
		HRTIMER_MODE_REL = 0x1, /* Time value is relative to now */
		HRTIMER_MODE_PINNED = 0x02, /* Timer is bound to CPU */
		HRTIMER_MODE_ABS_PINNED = 0x02,
		HRTIMER_MODE_REL_PINNED = 0x03,
		HRTIMER_MODE_ABS = 0x00,
		HRTIMER_MODE_REL = 0x01,
		HRTIMER_MODE_PINNED = 0x02,

		HRTIMER_MODE_ABS_PINNED = HRTIMER_MODE_ABS \| HRTIMER_MODE_PINNED,
		HRTIMER_MODE_REL_PINNED = HRTIMER_MODE_REL \| HRTIMER_MODE_PINNED,
		};

		/*