Commit 198e9770 authored Sep 23, 2022 by Wang Yufen Committed by Greg Kroah-Hartman Oct 05, 2022

selftests: Fix the if conditions of in test_extra_filter()



[ Upstream commit bc7a319844891746135dc1f34ab9df78d636a3ac ]

The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So
if bind success or errno != EADDRINUSE, testcase should be failed.

Fixes: 3ca8e402 ("soreuseport: BPF selection functional test")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Link: https://lore.kernel.org/r/1663916557-10730-1-git-send-email-wangyufen@huawei.com


Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5f7fd71e

tools/testing/selftests/net/reuseport_bpf.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -330,7 +330,7 @@ static void test_extra_filter(const struct test_params p)
	if (bind(fd1, addr, sockaddr_size()))		if (bind(fd1, addr, sockaddr_size()))
	error(1, errno, "failed to bind recv socket 1");		error(1, errno, "failed to bind recv socket 1");

	if (!bind(fd2, addr, sockaddr_size()) && errno != EADDRINUSE)		if (!bind(fd2, addr, sockaddr_size()) \|\| errno != EADDRINUSE)
	error(1, errno, "bind socket 2 should fail with EADDRINUSE");		error(1, errno, "bind socket 2 should fail with EADDRINUSE");

	free(addr);		free(addr);