Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 194ced7a authored by Max Kellermann's avatar Max Kellermann Committed by Mauro Carvalho Chehab
Browse files

[media] dvb_frontend: tuner_ops.release returns void 



It is not clear what this return value means.  All implemenations
return 0, and the one caller ignores the value.  Let's remove this
useless return value completely.

Signed-off-by: default avatarMax Kellermann <max.kellermann@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 22a613e8

drivers/media/dvb-core/dvb_frontend.c

+1 −2
Original line number Diff line number Diff line
@@ -174,12 +174,11 @@ static bool has_get_frontend(struct dvb_frontend *fe) 
	return fe->ops.get_frontend != NULL;

}



int

void

dvb_tuner_simple_release(struct dvb_frontend *fe)

{

	kfree(fe->tuner_priv);

	fe->tuner_priv = NULL;

	return 0;

}

EXPORT_SYMBOL(dvb_tuner_simple_release);

drivers/media/dvb-core/dvb_frontend.h

+2 −2
Original line number Diff line number Diff line
@@ -225,7 +225,7 @@ struct dvb_tuner_ops { 


	struct dvb_tuner_info info;



	int (*release)(struct dvb_frontend *fe);

	void (*release)(struct dvb_frontend *fe);

	int (*init)(struct dvb_frontend *fe);

	int (*sleep)(struct dvb_frontend *fe);

	int (*suspend)(struct dvb_frontend *fe);
@@ -270,7 +270,7 @@ struct dvb_tuner_ops { 
 * A common default implementation for dvb_tuner_ops.release.  All it

 * does is kfree() the tuner_priv and assign NULL to it.

 */

int

void

dvb_tuner_simple_release(struct dvb_frontend *fe);



/**

drivers/media/dvb-frontends/ascot2e.c

+1 −2
Original line number Diff line number Diff line
@@ -254,14 +254,13 @@ static int ascot2e_init(struct dvb_frontend *fe) 
	return ascot2e_leave_power_save(priv);

}



static int ascot2e_release(struct dvb_frontend *fe)

static void ascot2e_release(struct dvb_frontend *fe)

{

	struct ascot2e_priv *priv = fe->tuner_priv;



	dev_dbg(&priv->i2c->dev, "%s()\n", __func__);

	kfree(fe->tuner_priv);

	fe->tuner_priv = NULL;

	return 0;

}



static int ascot2e_sleep(struct dvb_frontend *fe)

drivers/media/dvb-frontends/cx24113.c

+1 −2
Original line number Diff line number Diff line
@@ -527,13 +527,12 @@ static int cx24113_get_frequency(struct dvb_frontend *fe, u32 *frequency) 
	return 0;

}



static int cx24113_release(struct dvb_frontend *fe)

static void cx24113_release(struct dvb_frontend *fe)

{

	struct cx24113_state *state = fe->tuner_priv;

	dprintk("\n");

	fe->tuner_priv = NULL;

	kfree(state);

	return 0;

}



static const struct dvb_tuner_ops cx24113_tuner_ops = {

drivers/media/dvb-frontends/helene.c

+1 −2
Original line number Diff line number Diff line
@@ -434,14 +434,13 @@ static int helene_init(struct dvb_frontend *fe) 
	return helene_leave_power_save(priv);

}



static int helene_release(struct dvb_frontend *fe)

static void helene_release(struct dvb_frontend *fe)

{

	struct helene_priv *priv = fe->tuner_priv;



	dev_dbg(&priv->i2c->dev, "%s()\n", __func__);

	kfree(fe->tuner_priv);

	fe->tuner_priv = NULL;

	return 0;

}



static int helene_sleep(struct dvb_frontend *fe)