Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1940f240 authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by David S. Miller
Browse files

sh_eth: no need for *else* after *goto* 



Well, checkpatch.pl complains about *else* after *return* and *break* but
not after *goto*... and it probably should have complained about the code
in sh_eth_error().  Win couple LoCs by removing that *else*. :-)

Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 40634699

drivers/net/ethernet/renesas/sh_eth.c

+4 −6
Original line number Diff line number Diff line
@@ -1542,13 +1542,11 @@ static void sh_eth_error(struct net_device *ndev, u32 intr_status) 
			ndev->stats.tx_carrier_errors++;

		if (felic_stat & ECSR_LCHNG) {

			/* Link Changed */

			if (mdp->cd->no_psr || mdp->no_ether_link) {

			if (mdp->cd->no_psr || mdp->no_ether_link)

				goto ignore_link;

			} else {

				link_stat = (sh_eth_read(ndev, PSR));

			link_stat = sh_eth_read(ndev, PSR);

			if (mdp->ether_link_active_low)

				link_stat = ~link_stat;

			}

			if (!(link_stat & PHY_ST_LINK)) {

				sh_eth_rcv_snd_disable(ndev);

			} else {