Commit 19318de1 authored May 18, 2014 by Christian Engelmayer Committed by Dmitry Torokhov May 18, 2014

Input: ims-pcu - fix uninitialized use of 'error' in ims_pcu_buffers_alloc()



In case allocation via usb_alloc_coherent() fails in ims_pcu_buffers_alloc(),
the function jumps to the exit path without initializing local variable
'error' that is used as return value. Detected by Coverity - CID 1016531.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 90550e6f

drivers/input/misc/ims-pcu.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1566,6 +1566,7 @@ static int ims_pcu_buffers_alloc(struct ims_pcu *pcu)
		if (!pcu->urb_ctrl_buf) {
		dev_err(pcu->dev,
		"Failed to allocate memory for read buffer\n");
		error = -ENOMEM;
		goto err_free_urb_out_buf;
		}