Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 191f1aee authored by Dan Carpenter's avatar Dan Carpenter Committed by Kalle Valo
Browse files

ath9k_htc: memory corruption calling set_bit() 



In d8a2c51c ('ath9k_htc: Use atomic operations for op_flags') we
changed things like this:

-	if (priv->op_flags & OP_TSF_RESET) {
+	if (test_bit(OP_TSF_RESET, &priv->op_flags)) {

The problem is that test_bit() takes a bit number and not a mask.  It
means that when we do:

	set_bit(OP_TSF_RESET, &priv->op_flags);

Then it sets the (1 << 6) bit instead of the 6 bit so we are setting a
bit which is past the end of the unsigned long.

Fixes: d8a2c51c ('ath9k_htc: Use atomic operations for op_flags')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 22f44150

drivers/net/wireless/ath/ath9k/htc.h

+3 −3
Original line number Diff line number Diff line
@@ -440,9 +440,9 @@ static inline void ath9k_htc_stop_btcoex(struct ath9k_htc_priv *priv) 
}

#endif /* CONFIG_ATH9K_BTCOEX_SUPPORT */



#define OP_BT_PRIORITY_DETECTED    BIT(3)

#define OP_BT_SCAN                 BIT(4)

#define OP_TSF_RESET               BIT(6)

#define OP_BT_PRIORITY_DETECTED    3

#define OP_BT_SCAN                 4

#define OP_TSF_RESET               6



enum htc_op_flags {

	HTC_FWFLAG_NO_RMW,