Commit 187226f5 authored Aug 22, 2007 by John Stultz Committed by Linus Torvalds Aug 22, 2007

futex_unlock_pi() hurts my brain and may cause application deadlock



Avoid futex_unlock_pi returning -EFAULT (which results in deadlock), by
clearing uval before jumping to retry_locked.

Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 42b88e6a

kernel/futex.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1670,6 +1670,7 @@ static int futex_unlock_pi(u32 __user uaddr, struct rw_semaphore fshared)
		attempt);
		if (ret)
		goto out;
		uval = 0;
		goto retry_unlocked;
		}