Commit 17c048fc authored May 11, 2014 by Josef Gajdusek Committed by Guenter Roeck May 12, 2014

hwmon: (emc1403) fix inverted store_hyst()



Attempts to set the hysteresis value to a temperature below the target
limit fails with "write error: Numerical result out of range" due to
an inverted comparison.

Signed-off-by: Josef Gajdusek <atx@atx.name>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org
[Guenter Roeck: Updated headline and description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent d6d211db

drivers/hwmon/emc1403.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -163,7 +163,7 @@ static ssize_t store_hyst(struct device *dev,
		if (retval < 0)
		goto fail;

		hyst = val - retval * 1000;
		hyst = retval * 1000 - val;
		hyst = DIV_ROUND_CLOSEST(hyst, 1000);
		if (hyst < 0 \|\| hyst > 255) {
		retval = -ERANGE;