Commit 1734bffc authored Jan 06, 2015 by Michael S. Tsirkin

blackfin: fix put_user sparse errors



virtio wants to write bitwise types to userspace using put_user.
At the moment this triggers sparse errors, since the value is passed
through an integer.

For example:

	__le32 __user *p;
	__le32 x;
	put_user(x, p);

is safe, but currently triggers a sparse warning.

Fix that up using __force.

Note: this does not suppress any useful sparse checks since caller
assigns x to typeof(*p), which in turn forces all the necessary type
checks.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent e8b94dea

arch/blackfin/include/asm/uaccess.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -89,10 +89,10 @@ struct exception_table_entry {
		break; \
		case 8: { \
		long _xl, _xh; \
		_xl = ((long *)&_x)[0]; \
		_xh = ((long *)&_x)[1]; \
		__put_user_asm(_xl, ((long __user *)_p)+0, ); \
		__put_user_asm(_xh, ((long __user *)_p)+1, ); \
		_xl = ((__force long *)&_x)[0]; \
		_xh = ((__force long *)&_x)[1]; \
		__put_user_asm(_xl, ((__force long __user *)_p)+0, );\
		__put_user_asm(_xh, ((__force long __user *)_p)+1, );\
		} break; \
		default: \
		_err = __put_user_bad(); \