Commit 172c529c authored Sep 29, 2019 by Vladimir Oltean Committed by Greg Kroah-Hartman Jan 27, 2020

net: sched: cbs: Avoid division by zero when calculating the port rate



[ Upstream commit 83c8c3cf45163f0c823db37be6ab04dfcf8ac751 ]

As explained in the "net: sched: taprio: Avoid division by zero on
invalid link speed" commit, it is legal for the ethtool API to return
zero as a link speed. So guard against it to ensure we don't perform a
division by zero in kernel.

Fixes: e0a7683d30e9 ("net/sched: cbs: fix port_rate miscalculation")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 13260106

net/sched/sch_cbs.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -310,7 +310,7 @@ static void cbs_set_port_rate(struct net_device dev, struct cbs_sched_data q)
	if (err < 0)		if (err < 0)
	goto skip;		goto skip;

	if (ecmd.base.speed != SPEED_UNKNOWN)		if (ecmd.base.speed && ecmd.base.speed != SPEED_UNKNOWN)
	speed = ecmd.base.speed;		speed = ecmd.base.speed;

	skip:		skip: