Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1711b877 authored by Marek Vasut's avatar Marek Vasut Committed by Greg Kroah-Hartman
Browse files

video: backlight: Drop maximum brightness override for brightness zero 



commit 33a5471f8da976bf271a1ebbd6b9d163cb0cb6aa upstream.

The note in c2adda27 ("video: backlight: Add of_find_backlight helper
in backlight.c") says that gpio-backlight uses brightness as power state.
This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight:
Correct initial power state handling") and other backlight drivers do not
require this workaround. Drop the workaround.

This fixes the case where e.g. pwm-backlight can perfectly well be set to
brightness 0 on boot in DT, which without this patch leads to the display
brightness to be max instead of off.

Fixes: c2adda27 ("video: backlight: Add of_find_backlight helper in backlight.c")
Cc: <stable@vger.kernel.org> # 5.4+
Cc: <stable@vger.kernel.org> # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling
Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Acked-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f928dae9

drivers/video/backlight/backlight.c

+0 −6
Original line number Diff line number Diff line
@@ -610,12 +610,6 @@ struct backlight_device *of_find_backlight(struct device *dev) 
			of_node_put(np);

			if (!bd)

				return ERR_PTR(-EPROBE_DEFER);

			/*

			 * Note: gpio_backlight uses brightness as

			 * power state during probe

			 */

			if (!bd->props.brightness)

				bd->props.brightness = bd->props.max_brightness;

		}

	}