Commit 170df32c authored May 07, 2018 by Sakari Ailus Committed by Mauro Carvalho Chehab May 09, 2018

media: omap3isp: Remove useless NULL check in omap3isp_stat_config

The omap3isp driver checked whether the second argument (the new
configuration) to the ISP statistics is NULL. This is the pointer to the
user-given argument and is never NULL. Remove the check.

Reported-by: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 378e3f81

drivers/media/platform/omap3isp/ispstat.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -544,12 +544,6 @@ int omap3isp_stat_config(struct ispstat stat, void new_conf)
		struct ispstat_generic_config *user_cfg = new_conf;
		u32 buf_size = user_cfg->buf_size;

		if (!new_conf) {
		dev_dbg(stat->isp->dev, "%s: configuration is NULL\n",
		stat->subdev.name);
		return -EINVAL;
		}

		mutex_lock(&stat->ioctl_lock);

		dev_dbg(stat->isp->dev,