Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16b9ce83 authored by Markus Pargmann's avatar Markus Pargmann Committed by Antonio Quartulli
Browse files

batman-adv: tvlv realloc, move error handling into if block 



Instead of hiding the normal function flow inside an if block, we should
just put the error handling into the if block.

Signed-off-by: default avatarMarkus Pargmann <mpa@pengutronix.de>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
parent 9bb21882

net/batman-adv/main.c

+8 −8
Original line number Diff line number Diff line
@@ -819,15 +819,15 @@ static bool batadv_tvlv_realloc_packet_buff(unsigned char **packet_buff, 
	new_buff = kmalloc(min_packet_len + additional_packet_len, GFP_ATOMIC);



	/* keep old buffer if kmalloc should fail */

	if (new_buff) {

	if (!new_buff)

		return false;



	memcpy(new_buff, *packet_buff, min_packet_len);

	kfree(*packet_buff);

	*packet_buff = new_buff;

	*packet_buff_len = min_packet_len + additional_packet_len;

		return true;

	}



	return false;

	return true;

}



/**