Commit 16a41423 authored Apr 24, 2014 by Marek Lindner Committed by Antonio Quartulli May 15, 2014

batman-adv: fix indirect hard_iface NULL dereference



If hard_iface is NULL and goto out is made batadv_hardif_free_ref()
doesn't check for NULL before dereferencing it to get to refcount.

Introduced in cb1c92ec
("batman-adv: add debugfs support to view multiif tables").

Reported-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Acked-by: Antonio Quartulli <antonio@meshcoding.com>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>

parent e84d2f8d

net/batman-adv/originator.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1079,6 +1079,7 @@ int batadv_orig_hardif_seq_print_text(struct seq_file seq, void offset)
		bat_priv->bat_algo_ops->bat_orig_print(bat_priv, seq, hard_iface);

		out:
		if (hard_iface)
		batadv_hardif_free_ref(hard_iface);
		return 0;
		}