Commit 1684dd03 authored Jun 14, 2017 by Yan, Zheng Committed by Ilya Dryomov Jul 07, 2017

ceph: getattr before read on ceph.* xattrs

Previously we were returning values for quota, layout
xattrs without any kind of update -- the user just got
whatever happened to be in our cache.

Clearly this extra round trip has a cost, but reads of
these xattrs are fairly rare, happening on admin
intervention rather than in normal operation.

Link: http://tracker.ceph.com/issues/17939


Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent 92e57e62

fs/ceph/xattr.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -756,6 +756,9 @@ ssize_t __ceph_getxattr(struct inode inode, const char name, void *value,
		/* let's see if a virtual xattr was requested */
		vxattr = ceph_match_vxattr(inode, name);
		if (vxattr) {
		err = ceph_do_getattr(inode, 0, true);
		if (err)
		return err;
		err = -ENODATA;
		if (!(vxattr->exists_cb && !vxattr->exists_cb(ci)))
		err = vxattr->getxattr_cb(ci, value, size);