Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 168316db authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Theodore Ts'o
Browse files

dax: assert that i_rwsem is held exclusive for writes 



Make sure all callers follow the same locking protocol, given that DAX
transparantly replaced the normal buffered I/O path.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
parent ff5462e3

fs/dax.c

+5 −1
Original line number Diff line number Diff line
@@ -1061,8 +1061,12 @@ dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter, 
	loff_t pos = iocb->ki_pos, ret = 0, done = 0;

	unsigned flags = 0;



	if (iov_iter_rw(iter) == WRITE)

	if (iov_iter_rw(iter) == WRITE) {

		lockdep_assert_held_exclusive(&inode->i_rwsem);

		flags |= IOMAP_WRITE;

	} else {

		lockdep_assert_held(&inode->i_rwsem);

	}



	while (iov_iter_count(iter)) {

		ret = iomap_apply(inode, pos, iov_iter_count(iter), flags, ops,