Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 166ffccf authored by Luiz Fernando N. Capitulino's avatar Luiz Fernando N. Capitulino Committed by Greg Kroah-Hartman
Browse files

[PATCH] USB: Anydata: Fixes wrong URB callback. 



 Anydata is using usb_serial_generic_write_bulk_callback() for its
read URB, but it should use usb_serial_generic_read_bulk_callback()
instead (it's a read URB, isn't it?).

 Reported by Jon K Hellan <hellan@acm.org>.

Signed-off-by: default avatarLuiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a353678d

drivers/usb/serial/anydata.c

+1 −1
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ static int anydata_open(struct usb_serial_port *port, struct file *filp) 
				  	  port->bulk_in_endpointAddress),

			  port->read_urb->transfer_buffer,

			  port->read_urb->transfer_buffer_length,

			  usb_serial_generic_write_bulk_callback, port);

			  usb_serial_generic_read_bulk_callback, port);

	result = usb_submit_urb(port->read_urb, GFP_KERNEL);

	if (result)

		dev_err(&port->dev,

drivers/usb/serial/generic.c

+1 −0
Original line number Diff line number Diff line
@@ -285,6 +285,7 @@ void usb_serial_generic_read_bulk_callback (struct urb *urb, struct pt_regs *reg 
	if (result)

		dev_err(&port->dev, "%s - failed resubmitting read urb, error %d\n", __FUNCTION__, result);

}

EXPORT_SYMBOL_GPL(usb_serial_generic_read_bulk_callback);



void usb_serial_generic_write_bulk_callback (struct urb *urb, struct pt_regs *regs)

{