Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1667c942 authored by Joe Perches's avatar Joe Perches Committed by David S. Miller
Browse files

netconsole: Use eth_<foo>_addr instead of memset 



Use the built-in function instead of memset.

Miscellanea:

Add #include <linux/etherdevice.h>

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 93803b33

drivers/net/netconsole.c

+3 −2
Original line number Diff line number Diff line
@@ -47,6 +47,7 @@ 
#include <linux/netpoll.h>

#include <linux/inet.h>

#include <linux/configfs.h>

#include <linux/etherdevice.h>



MODULE_AUTHOR("Maintainer: Matt Mackall <mpm@selenic.com>");

MODULE_DESCRIPTION("Console driver for network interfaces");
@@ -185,7 +186,7 @@ static struct netconsole_target *alloc_param_target(char *target_config) 
	nt->np.local_port = 6665;

	nt->np.remote_port = 6666;

	mutex_init(&nt->mutex);

	memset(nt->np.remote_mac, 0xff, ETH_ALEN);

	eth_broadcast_addr(nt->np.remote_mac);



	/* Parse parameters and setup netpoll */

	err = netpoll_parse_options(&nt->np, target_config);
@@ -604,7 +605,7 @@ static struct config_item *make_netconsole_target(struct config_group *group, 
	nt->np.local_port = 6665;

	nt->np.remote_port = 6666;

	mutex_init(&nt->mutex);

	memset(nt->np.remote_mac, 0xff, ETH_ALEN);

	eth_broadcast_addr(nt->np.remote_mac);



	/* Initialize the config_item member */

	config_item_init_type_name(&nt->item, name, &netconsole_target_type);