Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1661f2e2 authored by Vlastimil Babka's avatar Vlastimil Babka Committed by Jens Axboe
Browse files

floppy: replace wrong kmalloc(GFP_USER) with GFP_KERNEL 



The raw_cmd_copyin() function does a kmalloc() with GFP_USER, although the
allocated structure is obviously not mapped to userspace, just copied from/to.
In this case GFP_KERNEL is more appropriate, so let's use it, although in the
current implementation this does not manifest as any error.

Reported-by: default avatarMatthew Wilcox <mawilcox@linuxonhyperv.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent a121103c

drivers/block/floppy.c

+1 −1
Original line number Diff line number Diff line
@@ -3119,7 +3119,7 @@ static int raw_cmd_copyin(int cmd, void __user *param, 
	*rcmd = NULL;



loop:

	ptr = kmalloc(sizeof(struct floppy_raw_cmd), GFP_USER);

	ptr = kmalloc(sizeof(struct floppy_raw_cmd), GFP_KERNEL);

	if (!ptr)

		return -ENOMEM;

	*rcmd = ptr;