Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1648a22b authored by Vipul Pandya's avatar Vipul Pandya Committed by David S. Miller
Browse files

cxgb4: Inform caller if driver didn't upgrade firmware 



If a card had already been initialized, on reloading cxgb4 driver firmware
required an upgrade but the upgrade did not happen. In that case a mailbox
timeout would occur during T4 configuration file stuff. The fix is to let the
caller know the firmware was not upgraded so a reset would be issued before
starting the T4 config stuff.

Signed-off-by: default avatarJay Hernandez <jay@chelsio.com>
Signed-off-by: default avatarVipul Pandya <vipul@chelsio.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 13ee15d3

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

+6 −0
Original line number Diff line number Diff line
@@ -933,7 +933,13 @@ static int upgrade_fw(struct adapter *adap) 
		if (!ret)

			dev_info(dev, "firmware upgraded to version %pI4 from "

				 FW_FNAME "\n", &hdr->fw_ver);

	} else {

		/*

		 * Tell our caller that we didn't upgrade the firmware.

		 */

		ret = -EINVAL;

	}



out:	release_firmware(fw);

	return ret;

}