Commit 162bd5e5 authored Dec 12, 2017 by Jia-Ju Bai Committed by Johannes Berg Dec 19, 2017

mac80211_hwsim: Fix a possible sleep-in-atomic bug in hwsim_get_radio_nl



The driver may sleep under a spinlock.
The function call path is:
hwsim_get_radio_nl (acquire the spinlock)
  nlmsg_new(GFP_KERNEL) --> may sleep

To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 5d324073

drivers/net/wireless/mac80211_hwsim.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3216,7 +3216,7 @@ static int hwsim_get_radio_nl(struct sk_buff msg, struct genl_info info)
		if (!net_eq(wiphy_net(data->hw->wiphy), genl_info_net(info)))
		continue;

		skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
		skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_ATOMIC);
		if (!skb) {
		res = -ENOMEM;
		goto out_err;