Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15a09342 authored by Sachin Kamat's avatar Sachin Kamat Committed by Mauro Carvalho Chehab
Browse files

[media] soc_camera/sh_mobile_ceu_camera: Convert to devm_ioremap_resource() 



Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent bff79939

drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c

+4 −5
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 
#include <linux/completion.h>

#include <linux/delay.h>

#include <linux/dma-mapping.h>

#include <linux/err.h>

#include <linux/errno.h>

#include <linux/fs.h>

#include <linux/interrupt.h>
@@ -2111,11 +2112,9 @@ static int sh_mobile_ceu_probe(struct platform_device *pdev) 
	pcdev->max_width = pcdev->pdata->max_width ? : 2560;

	pcdev->max_height = pcdev->pdata->max_height ? : 1920;



	base = devm_request_and_ioremap(&pdev->dev, res);

	if (!base) {

		dev_err(&pdev->dev, "Unable to ioremap CEU registers.\n");

		return -ENXIO;

	}

	base = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(base))

		return PTR_ERR(base);



	pcdev->irq = irq;

	pcdev->base = base;