Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 158aeefc authored by Joe Perches's avatar Joe Perches Committed by Mauro Carvalho Chehab
Browse files

[media] atomisp: Add __printf validation and fix fallout 



__printf validation adds format and argument validation.

Fix the various broken format/argument mismatches.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent f2c61f98

drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c

+3 −3
Original line number Diff line number Diff line
@@ -265,7 +265,7 @@ ia_css_translate_dvs_statistics( 
	assert(isp_stats->hor_proj != NULL);

	assert(isp_stats->ver_proj != NULL);



	IA_CSS_ENTER("hproj=%p, vproj=%p, haddr=%x, vaddr=%x",

	IA_CSS_ENTER("hproj=%p, vproj=%p, haddr=%p, vaddr=%p",

		     host_stats->hor_proj, host_stats->ver_proj,

		     isp_stats->hor_proj, isp_stats->ver_proj);

drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/sdis/sdis_2/ia_css_sdis2.host.c

+1 −1
Original line number Diff line number Diff line
@@ -213,7 +213,7 @@ ia_css_translate_dvs2_statistics( 
		     "hor_coefs.even_real=%p, hor_coefs.even_imag=%p, "

		     "ver_coefs.odd_real=%p, ver_coefs.odd_imag=%p, "

		     "ver_coefs.even_real=%p, ver_coefs.even_imag=%p, "

		     "haddr=%x, vaddr=%x",

		     "haddr=%p, vaddr=%p",

		host_stats->hor_prod.odd_real, host_stats->hor_prod.odd_imag,

		host_stats->hor_prod.even_real, host_stats->hor_prod.even_imag,

		host_stats->ver_prod.odd_real, host_stats->ver_prod.odd_imag,

drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/tnr/tnr_1.0/ia_css_tnr.host.c

+1 −1
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ ia_css_tnr_dump( 
			"tnr_coef", tnr->coef);

	ia_css_debug_dtrace(level, "\t%-32s = %d\n",

			"tnr_threshold_Y", tnr->threshold_Y);

	ia_css_debug_dtrace(level, "\t%-32s = %d\n"

	ia_css_debug_dtrace(level, "\t%-32s = %d\n",

			"tnr_threshold_C", tnr->threshold_C);

}

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/interface/ia_css_debug.h

+1 −0
Original line number Diff line number Diff line
@@ -137,6 +137,7 @@ ia_css_debug_vdtrace(unsigned int level, const char *fmt, va_list args) 
		sh_css_vprint(fmt, args);

}



__printf(2, 3)

extern void ia_css_debug_dtrace(unsigned int level, const char *fmt, ...);



/*! @brief Dump sp thread's stack contents

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c

+3 −3
Original line number Diff line number Diff line
@@ -3148,7 +3148,7 @@ ia_css_debug_dump_pipe_config( 
		ia_css_debug_dump_frame_info(&config->vf_output_info[i],

				"vf_output_info");

	}

	ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "acc_extension: 0x%x\n",

	ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "acc_extension: %p\n",

			    config->acc_extension);

	ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "num_acc_stages: %d\n",

			config->num_acc_stages);
@@ -3179,7 +3179,7 @@ ia_css_debug_dump_stream_config_source( 
		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "timeout: %d\n",

				config->source.port.timeout);

		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "compression: %d\n",

				config->source.port.compression);

				config->source.port.compression.type);

		break;

	case IA_CSS_INPUT_MODE_TPG:

		ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE, "source.tpg\n");