Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14edbde1 authored by Baoyou Xie's avatar Baoyou Xie Committed by Rob Clark
Browse files

drm/msm/mdp4: mark symbols static where possible 



We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c:96:23: warning: no previous prototype for 'get_connector' [-Wmissing-prototypes]
drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c:84:5: warning: no previous prototype for 'mdp4_plane_set_property' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.

Signed-off-by: default avatarBaoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: default avatarArchit Taneja <architt@codeaurora.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent f755e227

drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -93,7 +93,7 @@ static const struct drm_encoder_funcs mdp4_lcdc_encoder_funcs = { 
};

};





/* this should probably be a helper: */

/* this should probably be a helper: */

struct drm_connector *get_connector(struct drm_encoder *encoder)

static struct drm_connector *get_connector(struct drm_encoder *encoder)

{

{

	struct drm_device *dev = encoder->dev;

	struct drm_device *dev = encoder->dev;

	struct drm_connector *connector;

	struct drm_connector *connector;

drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -81,7 +81,7 @@ static void mdp4_plane_install_properties(struct drm_plane *plane, 
	// XXX

	// XXX

}

}





int mdp4_plane_set_property(struct drm_plane *plane,

static int mdp4_plane_set_property(struct drm_plane *plane,

		struct drm_property *property, uint64_t val)

		struct drm_property *property, uint64_t val)

{

{

	// XXX

	// XXX