Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14b055f4 authored by Fabio Estevam's avatar Fabio Estevam Committed by Li Yang
Browse files

soc: fsl: guts: Add a NULL check for devm_kasprintf() 



devm_kasprintf() may fail, so we should better add a NULL check
and propagate an error on failure.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
Acked-by: default avatarYangbo Lu <yangbo.lu@nxp.com>
Signed-off-by: default avatarLi Yang <leoyang.li@nxp.com>
parent 6ea0acfd

drivers/soc/fsl/guts.c

+6 −0
Original line number Diff line number Diff line
@@ -167,10 +167,16 @@ static int fsl_guts_probe(struct platform_device *pdev) 
	} else {

		soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, "QorIQ");

	}

	if (!soc_dev_attr.family)

		return -ENOMEM;

	soc_dev_attr.soc_id = devm_kasprintf(dev, GFP_KERNEL,

					     "svr:0x%08x", svr);

	if (!soc_dev_attr.soc_id)

		return -ENOMEM;

	soc_dev_attr.revision = devm_kasprintf(dev, GFP_KERNEL, "%d.%d",

					       (svr >>  4) & 0xf, svr & 0xf);

	if (!soc_dev_attr.revision)

		return -ENOMEM;



	soc_dev = soc_device_register(&soc_dev_attr);

	if (IS_ERR(soc_dev))