Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14563a4e authored by Ben Dooks's avatar Ben Dooks Committed by Linus Torvalds
Browse files

backlight: add more information output to pwm_backlight 



Make the error paths in the pwm_backlight driver more informative in the
probe path, especially for the times that it finds an error.

Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Acked-by: default avatarKrzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 26cb8bb2

drivers/video/backlight/pwm_bl.c

+6 −2
Original line number Diff line number Diff line
@@ -68,8 +68,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) 
	struct pwm_bl_data *pb;

	int ret;



	if (!data)

	if (!data) {

		dev_err(&pdev->dev, "failed to find platform data\n");

		return -EINVAL;

	}



	if (data->init) {

		ret = data->init(&pdev->dev);
@@ -79,6 +81,7 @@ static int pwm_backlight_probe(struct platform_device *pdev) 


	pb = kzalloc(sizeof(*pb), GFP_KERNEL);

	if (!pb) {

		dev_err(&pdev->dev, "no memory for state\n");

		ret = -ENOMEM;

		goto err_alloc;

	}
@@ -91,7 +94,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) 
		dev_err(&pdev->dev, "unable to request PWM for backlight\n");

		ret = PTR_ERR(pb->pwm);

		goto err_pwm;

	}

	} else

		dev_dbg(&pdev->dev, "got pwm for backlight\n");



	bl = backlight_device_register(pdev->name, &pdev->dev,

			pb, &pwm_backlight_ops);