Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1412ee39 authored by Eyal Shapira's avatar Eyal Shapira Committed by Emmanuel Grumbach
Browse files

iwlwifi: mvm: drop low_latency_agg_frame_cnt_limit 



This was an old workaround for solving latency issues with
certain Miracast adapters like ActionTec. However this isn't
needed anymore and furthermore it hurts throughput in other
use cases.

Signed-off-by: default avatarEyal Shapira <eyalx.shapira@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 566f165d

drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c

+0 −4
Original line number Diff line number Diff line
@@ -1491,10 +1491,6 @@ int iwl_mvm_dbgfs_register(struct iwl_mvm *mvm, struct dentry *dbgfs_dir) 
		goto err;

#endif



	if (!debugfs_create_u8("low_latency_agg_frame_limit", S_IRUSR | S_IWUSR,

			       mvm->debugfs_dir,

			       &mvm->low_latency_agg_frame_limit))

		goto err;

	if (!debugfs_create_u8("ps_disabled", S_IRUSR,

			       mvm->debugfs_dir, &mvm->ps_disabled))

		goto err;

drivers/net/wireless/intel/iwlwifi/mvm/mvm.h

+0 −2
Original line number Diff line number Diff line
@@ -813,8 +813,6 @@ struct iwl_mvm { 
	bool lar_regdom_set;

	enum iwl_mcc_source mcc_src;



	u8 low_latency_agg_frame_limit;



	/* TDLS channel switch data */

	struct {

		struct delayed_work dwork;

drivers/net/wireless/intel/iwlwifi/mvm/ops.c

+0 −1
Original line number Diff line number Diff line
@@ -452,7 +452,6 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg, 
		mvm->first_agg_queue = 12;

	}

	mvm->sf_state = SF_UNINIT;

	mvm->low_latency_agg_frame_limit = 6;

	mvm->cur_ucode = IWL_UCODE_INIT;



	mutex_init(&mvm->mutex);

drivers/net/wireless/intel/iwlwifi/mvm/rs.c

+1 −7
Original line number Diff line number Diff line
@@ -3454,15 +3454,9 @@ static void rs_fill_lq_cmd(struct iwl_mvm *mvm, 
	 * Tx Fifo so that it can start a transaction in the same TxOP. This

	 * basically allows the firmware to send bursts.

	 */

	if (iwl_mvm_vif_low_latency(mvmvif)) {

	if (iwl_mvm_vif_low_latency(mvmvif))

		lq_cmd->agg_frame_cnt_limit--;



		if (mvm->low_latency_agg_frame_limit)

			lq_cmd->agg_frame_cnt_limit =

				min(lq_cmd->agg_frame_cnt_limit,

				    mvm->low_latency_agg_frame_limit);

	}



	if (mvmsta->vif->p2p)

		lq_cmd->flags |= LQ_FLAG_USE_RTS_MSK;