Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13b631a5 authored by Kulikov Vasiliy's avatar Kulikov Vasiliy Committed by Greg Kroah-Hartman
Browse files

staging: vt6655: do not use PCI resources before pci_enable_device() 



IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.

The semantic match that finds this problem is as follows:

// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@

(
* x->irq
|
* x->resource
|
* request(x, ...)
)
 ...
*pci_enable_device(x)
// </smpl>

Signed-off-by: default avatarKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent bd2bc4c7

drivers/staging/vt6655/device_main.c

+2 −1
Original line number Diff line number Diff line
@@ -955,12 +955,13 @@ vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent) 
    pDevice->dev = dev;

    pDevice->next_module = root_device_dev;

    root_device_dev = dev;

    dev->irq = pcid->irq;



    if (pci_enable_device(pcid)) {

        device_free_info(pDevice);

        return -ENODEV;

    }

    dev->irq = pcid->irq;



#ifdef	DEBUG

	printk("Before get pci_info memaddr is %x\n",pDevice->memaddr);

#endif