Commit 13990f81 authored Oct 05, 2014 by John Fastabend Committed by David S. Miller Oct 06, 2014

net: sched: cls_cgroup tear down exts and ematch from rcu callback



It is not RCU safe to destroy the action chain while there
is a possibility of readers accessing it. Move this code
into the rcu callback using the same rcu callback used in the
code patch to make a change to head.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 82a470f1

net/sched/cls_cgroup.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -156,10 +156,8 @@ static void cls_cgroup_destroy(struct tcf_proto *tp)
		struct cls_cgroup_head *head = rtnl_dereference(tp->root);

		if (head) {
		tcf_exts_destroy(&head->exts);
		tcf_em_tree_destroy(&head->ematches);
		RCU_INIT_POINTER(tp->root, NULL);
		kfree_rcu(head, rcu);
		call_rcu(&head->rcu, cls_cgroup_destroy_rcu);
		}
		}