Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1377d8dd authored by Adrian Bunk's avatar Adrian Bunk Committed by James Bottomley
Browse files

[SCSI] FlashPoint: fix off-by-one errors 



This patch fixes off-by-one errors in error checks (the variables are
used as array indexes for arrays with MAX_SCSI_TAR resp. MAX_LUN
elements) spotted by the Coverity checker.

Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 2b48aed1

drivers/scsi/FlashPoint.c

+1 −1
Original line number Diff line number Diff line
@@ -1499,7 +1499,7 @@ static void FlashPoint_StartCCB(unsigned long pCurrCard, struct sccb *p_Sccb) 
	thisCard = ((struct sccb_card *)pCurrCard)->cardIndex;

	ioport = ((struct sccb_card *)pCurrCard)->ioPort;



	if ((p_Sccb->TargID > MAX_SCSI_TAR) || (p_Sccb->Lun > MAX_LUN)) {

	if ((p_Sccb->TargID >= MAX_SCSI_TAR) || (p_Sccb->Lun >= MAX_LUN)) {



		p_Sccb->HostStatus = SCCB_COMPLETE;

		p_Sccb->SccbStatus = SCCB_ERROR;