Commit 13405468 authored May 24, 2018 by Jakub Kicinski Committed by David S. Miller May 24, 2018

bpfilter: don't pass O_CREAT when opening console for debug



Passing O_CREAT (00000100) to open means we should also pass file
mode as the third parameter.  Creating /dev/console as a regular
file may not be helpful anyway, so simply drop the flag when
opening debug_fd.

Fixes: d2ba09c1 ("net: add skeleton of bpfilter kernel module")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 61a552eb

net/bpfilter/main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -55,7 +55,7 @@ static void loop(void)

		int main(void)
		{
		debug_fd = open("/dev/console", 00000002 \| 00000100);
		debug_fd = open("/dev/console", 00000002);
		dprintf(debug_fd, "Started bpfilter\n");
		loop();
		close(debug_fd);