Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1333b90f authored by Linus Walleij's avatar Linus Walleij
Browse files

gpio: do not set up hardware for IRQ_TYPE_NONE 



Some GPIO irqchip drivers exploit the irqdomain mapping
function to set up the IRQ default type in the hardware,
make sure that if we pass IRQ_TYPE_NONE, no hardware setup
whatsoever takes place (this should be the norm) until
later when the IRQ gets utilized.

Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Tested-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: default avatarJavier Martinez Canillas <javier@dowhile0.org>
Tested-by: default avatarNishanth Menon <nm@ti.com>
Acked-by: default avatarNishanth Menon <nm@ti.com>
Tested-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 95ad6b9d

drivers/gpio/gpiolib.c

+8 −2
Original line number Diff line number Diff line
@@ -1409,6 +1409,11 @@ static int gpiochip_irq_map(struct irq_domain *d, unsigned int irq, 
#else

	irq_set_noprobe(irq);

#endif

	/*

	 * No set-up of the hardware will happen if IRQ_TYPE_NONE

	 * is passed as default type.

	 */

	if (chip->irq_default_type != IRQ_TYPE_NONE)

		irq_set_irq_type(irq, chip->irq_default_type);



	return 0;
@@ -1490,7 +1495,8 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip) 
 * @first_irq: if not dynamically assigned, the base (first) IRQ to

 * allocate gpiochip irqs from

 * @handler: the irq handler to use (often a predefined irq core function)

 * @type: the default type for IRQs on this irqchip

 * @type: the default type for IRQs on this irqchip, pass IRQ_TYPE_NONE

 * to have the core avoid setting up any default type in the hardware.

 *

 * This function closely associates a certain irqchip with a certain

 * gpiochip, providing an irq domain to translate the local IRQs to