Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13143d2d authored by Sage Weil's avatar Sage Weil
Browse files

rbd: warn on update_snaps failure on notify 



Signed-off-by: default avatarSage Weil <sage@newdream.net>
parent 9d6fcb08

drivers/block/rbd.c

+6 −1
Original line number Original line Diff line number Diff line
@@ -1191,14 +1191,19 @@ static int rbd_req_sync_notify_ack(struct rbd_device *dev, 
static void rbd_watch_cb(u64 ver, u64 notify_id, u8 opcode, void *data)

static void rbd_watch_cb(u64 ver, u64 notify_id, u8 opcode, void *data)

{

{

	struct rbd_device *dev = (struct rbd_device *)data;

	struct rbd_device *dev = (struct rbd_device *)data;

	int rc;



	if (!dev)

	if (!dev)

		return;

		return;





	dout("rbd_watch_cb %s notify_id=%lld opcode=%d\n", dev->obj_md_name,

	dout("rbd_watch_cb %s notify_id=%lld opcode=%d\n", dev->obj_md_name,

		notify_id, (int)opcode);

		notify_id, (int)opcode);

	mutex_lock_nested(&ctl_mutex, SINGLE_DEPTH_NESTING);

	mutex_lock_nested(&ctl_mutex, SINGLE_DEPTH_NESTING);

	__rbd_update_snaps(dev);

	rc = __rbd_update_snaps(dev);

	mutex_unlock(&ctl_mutex);

	mutex_unlock(&ctl_mutex);

	if (rc)

		pr_warning(DRV_NAME "%d got notification but failed to update"

			   " snaps: %d\n", dev->major, rc);





	rbd_req_sync_notify_ack(dev, ver, notify_id, dev->obj_md_name);

	rbd_req_sync_notify_ack(dev, ver, notify_id, dev->obj_md_name);

}

}