Commit 12d866ec authored Jun 22, 2013 by Emil Goode Committed by Mauro Carvalho Chehab Jun 28, 2013

[media] saa7134: Fix sparse warnings by adding __user annotation



Adding a __user annotation fixes the following sparse warnings.
drivers/media/pci/saa7134/saa7134-video.c:1578:45: warning:
        incorrect type in initializer (different address spaces)
        drivers/media/pci/saa7134/saa7134-video.c:1578:45:
        expected struct v4l2_clip *clips
        drivers/media/pci/saa7134/saa7134-video.c:1578:45:
        got struct v4l2_clip [noderef] <asn:1>*clips
drivers/media/pci/saa7134/saa7134-video.c:1589:26: warning:
        incorrect type in assignment (different address spaces)
        drivers/media/pci/saa7134/saa7134-video.c:1589:26:
        expected struct v4l2_clip [noderef] <asn:1>*clips
        drivers/media/pci/saa7134/saa7134-video.c:1589:26:
        got struct v4l2_clip *clips

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent fd8d30bf

drivers/media/pci/saa7134/saa7134-video.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1575,7 +1575,7 @@ static int saa7134_g_fmt_vid_overlay(struct file file, void priv,
	{		{
	struct saa7134_fh *fh = priv;		struct saa7134_fh *fh = priv;
	struct saa7134_dev *dev = fh->dev;		struct saa7134_dev *dev = fh->dev;
	struct v4l2_clip *clips = f->fmt.win.clips;		struct v4l2_clip __user *clips = f->fmt.win.clips;
	u32 clipcount = f->fmt.win.clipcount;		u32 clipcount = f->fmt.win.clipcount;
	int err = 0;		int err = 0;
	int i;		int i;