Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12bcb3f7 authored by Dave Chinner's avatar Dave Chinner Committed by Ben Myers
Browse files

xfs: Properly exclude IO type flags from buffer flags 



Recent event tracing during a debugging session showed that flags
that define the IO type for a buffer are leaking into the flags on
the buffer incorrectly. Fix the flag exclusion mask in
xfs_buf_alloc() to avoid problems that may be caused by such
leakage.

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarMark Tinguely <tinguely@sgi.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent ad1e95c5

fs/xfs/xfs_buf.c

+3 −2
Original line number Diff line number Diff line
@@ -178,9 +178,10 @@ xfs_buf_alloc( 
		return NULL;



	/*

	 * We don't want certain flags to appear in b_flags.

	 * We don't want certain flags to appear in b_flags unless they are

	 * specifically set by later operations on the buffer.

	 */

	flags &= ~(XBF_MAPPED|XBF_READ_AHEAD);

	flags &= ~(XBF_MAPPED | XBF_TRYLOCK | XBF_ASYNC | XBF_READ_AHEAD);



	atomic_set(&bp->b_hold, 1);

	atomic_set(&bp->b_lru_ref, 1);