Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12a4bd31 authored by Markus Elfring's avatar Markus Elfring Committed by Herbert Xu
Browse files

crypto: qat - Deletion of unnecessary checks before two function calls 



The functions kfree() and release_firmware() test whether their argument
is NULL and then return immediately.
Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 44a17ef8

drivers/crypto/qat/qat_common/adf_accel_engine.c

+1 −4
Original line number Diff line number Diff line
@@ -88,10 +88,7 @@ void adf_ae_fw_release(struct adf_accel_dev *accel_dev) 


	qat_uclo_del_uof_obj(loader_data->fw_loader);

	qat_hal_deinit(loader_data->fw_loader);



	if (loader_data->uof_fw)

	release_firmware(loader_data->uof_fw);



	loader_data->uof_fw = NULL;

	loader_data->fw_loader = NULL;

}

drivers/crypto/qat/qat_common/adf_transport.c

+1 −1
Original line number Diff line number Diff line
@@ -449,7 +449,7 @@ static int adf_init_bank(struct adf_accel_dev *accel_dev, 
err:

	for (i = 0; i < ADF_ETR_MAX_RINGS_PER_BANK; i++) {

		ring = &bank->rings[i];

		if (hw_data->tx_rings_mask & (1 << i) && ring->inflights)

		if (hw_data->tx_rings_mask & (1 << i))

			kfree(ring->inflights);

	}

	return -ENOMEM;