Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12778fc1 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Dave Airlie
Browse files

drm/tilcdc: panel: Set return value explicitly 



Instead of setting an initial value for the return code, set it explicitly
on each error path. This is just a cosmetic cleanup, as preparation for the
enable GPIO support.

Tested-by: default avatarDarren Etheridge <detheridge@ti.com>
Tested-by: default avatarJohannes Pointner <johannes.pointner@br-automation.com>
Signed-off-by: default avatarEzequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 18c44db8

drivers/gpu/drm/tilcdc/tilcdc_panel.c

+3 −1
Original line number Diff line number Diff line
@@ -346,7 +346,7 @@ static int panel_probe(struct platform_device *pdev) 
	struct panel_module *panel_mod;

	struct tilcdc_module *mod;

	struct pinctrl *pinctrl;

	int ret = -EINVAL;

	int ret;



	/* bail out early if no DT data: */

	if (!node) {
@@ -381,12 +381,14 @@ static int panel_probe(struct platform_device *pdev) 
	panel_mod->timings = of_get_display_timings(node);

	if (!panel_mod->timings) {

		dev_err(&pdev->dev, "could not get panel timings\n");

		ret = -EINVAL;

		goto fail_free;

	}



	panel_mod->info = of_get_panel_info(node);

	if (!panel_mod->info) {

		dev_err(&pdev->dev, "could not get panel info\n");

		ret = -EINVAL;

		goto fail_timings;

	}