Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 118f3e1a authored by Tamas Vincze's avatar Tamas Vincze Committed by Linus Torvalds
Browse files

edac: i5000_edac critical fix panic out of bounds 

EDAC MC0: INTERNAL ERROR: channel-b out of range (4 >= 4)
Kernel panic - not syncing: EDAC MC0: Uncorrected Error  (XEN) Domain 0 crashed: 'noreboot' set - not rebooting.

This happens because FERR_NF_FBD bit 28 is not updated on i5000.  Due to
that, both bits 28 and 29 may be equal to one, returning channel = 3.  As
this value is invalid, EDAC core generates the panic.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14568



Signed-off-by: default avatarTamas Vincze <tom@vincze.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: default avatarDoug Thompson <dougthompson@xmission.com>
Cc: <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 355e8e8d

drivers/edac/i5000_edac.c

+7 −1
Original line number Diff line number Diff line
@@ -577,7 +577,13 @@ static void i5000_process_nonfatal_error_info(struct mem_ctl_info *mci, 
		debugf0("\tUncorrected bits= 0x%x\n", ue_errors);



		branch = EXTRACT_FBDCHAN_INDX(info->ferr_nf_fbd);

		channel = branch;



		/*

		 * According with i5000 datasheet, bit 28 has no significance

		 * for errors M4Err-M12Err and M17Err-M21Err, on FERR_NF_FBD

		 */

		channel = branch & 2;



		bank = NREC_BANK(info->nrecmema);

		rank = NREC_RANK(info->nrecmema);

		rdwr = NREC_RDWR(info->nrecmema);