Commit 117d15bb authored Nov 04, 2016 by Sowmini Varadhan Committed by David S. Miller Nov 09, 2016

RDS: TCP: start multipath acceptor loop at 0



The for() loop in rds_tcp_accept_one() assumes that the 0'th
rds_tcp_conn_path is UP and starts multipath accepts at index 1.
But this assumption may not always be true: if the 0'th path
has failed (ERROR or DOWN state) an incoming connection request
should be used to resurrect this path.

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1ac507d4

net/rds/tcp_listen.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -103,7 +103,7 @@ struct rds_tcp_connection rds_tcp_accept_one_path(struct rds_connection conn)
	if (!peer_is_smaller)		if (!peer_is_smaller)
	return NULL;		return NULL;

	for (i = 1; i < npaths; i++) {		for (i = 0; i < npaths; i++) {
	struct rds_conn_path *cp = &conn->c_path[i];		struct rds_conn_path *cp = &conn->c_path[i];

	if (rds_conn_path_transition(cp, RDS_CONN_DOWN,		if (rds_conn_path_transition(cp, RDS_CONN_DOWN,