Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 115003e9 authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Double check the active status on the batch pool 



We should not rely on obj->active being uptodate unless we manually
flush it. Instead, we can verify that the next available batch object is
idle by looking at its last active request (and checking it for
completion).

v2: remove the struct drm_device forward declaration added in the
process of removing its necessity

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470324762-2545-3-git-send-email-chris@chris-wilson.co.uk
parent e522ac23

drivers/gpu/drm/i915/i915_gem_batch_pool.c

+8 −7
Original line number Diff line number Diff line
@@ -41,15 +41,15 @@ 


/**

 * i915_gem_batch_pool_init() - initialize a batch buffer pool

 * @dev: the drm device

 * @engine: the associated request submission engine

 * @pool: the batch buffer pool

 */

void i915_gem_batch_pool_init(struct drm_device *dev,

void i915_gem_batch_pool_init(struct intel_engine_cs *engine,

			      struct i915_gem_batch_pool *pool)

{

	int n;



	pool->dev = dev;

	pool->engine = engine;



	for (n = 0; n < ARRAY_SIZE(pool->cache_list); n++)

		INIT_LIST_HEAD(&pool->cache_list[n]);
@@ -65,7 +65,7 @@ void i915_gem_batch_pool_fini(struct i915_gem_batch_pool *pool) 
{

	int n;



	WARN_ON(!mutex_is_locked(&pool->dev->struct_mutex));

	lockdep_assert_held(&pool->engine->i915->drm.struct_mutex);



	for (n = 0; n < ARRAY_SIZE(pool->cache_list); n++) {

		struct drm_i915_gem_object *obj, *next;
@@ -101,7 +101,7 @@ i915_gem_batch_pool_get(struct i915_gem_batch_pool *pool, 
	struct list_head *list;

	int n;



	WARN_ON(!mutex_is_locked(&pool->dev->struct_mutex));

	lockdep_assert_held(&pool->engine->i915->drm.struct_mutex);



	/* Compute a power-of-two bucket, but throw everything greater than

	 * 16KiB into the same bucket: i.e. the the buckets hold objects of
@@ -114,7 +114,8 @@ i915_gem_batch_pool_get(struct i915_gem_batch_pool *pool, 


	list_for_each_entry_safe(tmp, next, list, batch_pool_link) {

		/* The batches are strictly LRU ordered */

		if (tmp->active)

		if (!i915_gem_active_is_idle(&tmp->last_read[pool->engine->id],

					     &tmp->base.dev->struct_mutex))

			break;



		/* While we're looping, do some clean up */
@@ -133,7 +134,7 @@ i915_gem_batch_pool_get(struct i915_gem_batch_pool *pool, 
	if (obj == NULL) {

		int ret;



		obj = i915_gem_object_create(pool->dev, size);

		obj = i915_gem_object_create(&pool->engine->i915->drm, size);

		if (IS_ERR(obj))

			return obj;

drivers/gpu/drm/i915/i915_gem_batch_pool.h

+4 −2
Original line number Diff line number Diff line
@@ -27,13 +27,15 @@ 


#include "i915_drv.h"



struct intel_engine_cs;



struct i915_gem_batch_pool {

	struct drm_device *dev;

	struct intel_engine_cs *engine;

	struct list_head cache_list[4];

};



/* i915_gem_batch_pool.c */

void i915_gem_batch_pool_init(struct drm_device *dev,

void i915_gem_batch_pool_init(struct intel_engine_cs *engine,

			      struct i915_gem_batch_pool *pool);

void i915_gem_batch_pool_fini(struct i915_gem_batch_pool *pool);

struct drm_i915_gem_object*

drivers/gpu/drm/i915/intel_engine_cs.c

+1 −1
Original line number Diff line number Diff line
@@ -185,7 +185,7 @@ void intel_engine_setup_common(struct intel_engine_cs *engine) 
	engine->fence_context = fence_context_alloc(1);



	intel_engine_init_hangcheck(engine);

	i915_gem_batch_pool_init(&engine->i915->drm, &engine->batch_pool);

	i915_gem_batch_pool_init(engine, &engine->batch_pool);

}



/**