Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 112b0b79 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Jonathan Cameron
Browse files

staging:iio:ad7746: Do not store the transfer buffer on the stack 



Some I2C controllers might not be able to handle transfer buffers that are
stored on stack.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent d4adb07c

drivers/staging/iio/cdc/ad7746.c

+7 −7
Original line number Diff line number Diff line
@@ -105,6 +105,11 @@ struct ad7746_chip_info { 
	u8	vt_setup;

	u8	capdac[2][2];

	s8	capdac_set;



	union {

		__be32 d32;

		u8 d8[4];

	} data ____cacheline_aligned;

};



enum ad7746_chan {
@@ -566,11 +571,6 @@ static int ad7746_read_raw(struct iio_dev *indio_dev, 
	int ret, delay;

	u8 regval, reg;



	union {

		__be32 d32;

		u8 d8[4];

	} data;



	mutex_lock(&indio_dev->mlock);



	switch (mask) {
@@ -591,12 +591,12 @@ static int ad7746_read_raw(struct iio_dev *indio_dev, 
		/* Now read the actual register */



		ret = i2c_smbus_read_i2c_block_data(chip->client,

			chan->address >> 8, 3, &data.d8[1]);

			chan->address >> 8, 3, &chip->data.d8[1]);



		if (ret < 0)

			goto out;



		*val = (be32_to_cpu(data.d32) & 0xFFFFFF) - 0x800000;

		*val = (be32_to_cpu(chip->data.d32) & 0xFFFFFF) - 0x800000;



		switch (chan->type) {

		case IIO_TEMP: