Commit 10f0577a authored May 14, 2014 by Dan Carpenter Committed by Felipe Balbi May 14, 2014

usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()



There are several issues here:
1) platform_get_resource() can return NULL and that wasn't handled.
2) We should request the memory before we remap it, and
   devm_ioremap_resource() does that.
3) devm_ioremap() returns a NULL but we were checking for IS_ERR().

Fixes: 6b99c68e ('usb: phy: msm: Migrate to Managed Device Resource allocation')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent c5ab571f

drivers/usb/phy/phy-msm-usb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1586,7 +1586,7 @@ static int msm_otg_probe(struct platform_device *pdev)
		np ? "alt_core" : "usb_hs_core_clk");

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		motg->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
		motg->regs = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(motg->regs))
		return PTR_ERR(motg->regs);