Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10dc0358 authored by Anjali Singhai Jain's avatar Anjali Singhai Jain Committed by Jeff Kirsher
Browse files

i40e: fix a bug in debugfs with add/del macaddr 



The new code flow requires us to grab the filter list lock before
adding/deleting the filter.

Change-ID: I4eaef508ab4da2d1b2e23f20f2a78d931d5b6aeb
Signed-off-by: default avatarAnjali Singhai Jain <anjali.singhai@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent e7358f54

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -1137,7 +1137,9 @@ static ssize_t i40e_dbg_command_write(struct file *filp, 
			goto command_write_done;

			goto command_write_done;

		}

		}





		spin_lock_bh(&vsi->mac_filter_list_lock);

		f = i40e_add_filter(vsi, ma, vlan, false, false);

		f = i40e_add_filter(vsi, ma, vlan, false, false);

		spin_unlock_bh(&vsi->mac_filter_list_lock);

		ret = i40e_sync_vsi_filters(vsi, true);

		ret = i40e_sync_vsi_filters(vsi, true);

		if (f && !ret)

		if (f && !ret)

			dev_info(&pf->pdev->dev,

			dev_info(&pf->pdev->dev,
@@ -1174,7 +1176,9 @@ static ssize_t i40e_dbg_command_write(struct file *filp, 
			goto command_write_done;

			goto command_write_done;

		}

		}





		spin_lock_bh(&vsi->mac_filter_list_lock);

		i40e_del_filter(vsi, ma, vlan, false, false);

		i40e_del_filter(vsi, ma, vlan, false, false);

		spin_unlock_bh(&vsi->mac_filter_list_lock);

		ret = i40e_sync_vsi_filters(vsi, true);

		ret = i40e_sync_vsi_filters(vsi, true);

		if (!ret)

		if (!ret)

			dev_info(&pf->pdev->dev,

			dev_info(&pf->pdev->dev,